Master to 650 3 july 24 #1301
Merged
Master to 650 3 july 24 #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added condition on description and error message in aria-describedby
* FORMS-12203: Added localization changes and test cases * FORMS-12203: Updated test case * FORMS-12203: Altered to contains instead of get * FORMS-12203: Resolved comments * FORMS-12203: Updated test cases * FORMS-12203: Updated delete button * FORMS-12203: Updated button * Retry wizard.locale.spec.js tests * FORMS-12203: Added theme request wait * Update wizard.locale.spec.js * Added latestaddon check * Delete ui.tests/test-module/package-lock.json * Update commands.js * Revert "Delete ui.tests/test-module/package-lock.json" This reverts commit fd97b53. * Reverted package-lock.json changes * FORMS-12203: Removed exception inline * FORMS-12203: Resolved comments * FORMS-12203: Update index.js * FORMS-12203: Removed package-lock.json change * Update index.js * Update error message in index.js * Update index.js * Update wizard.locale.spec.js * Removed an intercept * Updated regex patterns --------- Co-authored-by: Shivangi Mittal <[email protected]>
#1195) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : format should not be visible when no pattern is selected
… selected (#1195)" This reverts commit 5c19a652671e4461tbec5a2677e3d918952c9ba67.
* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <[email protected]>
* FORMS-12203: Added localization changes and test cases * FORMS-12203: Updated test case * FORMS-12203: Altered to contains instead of get * FORMS-12203: Resolved comments * FORMS-12203: Updated test cases * FORMS-12203: Updated delete button * FORMS-12203: Updated button * Retry wizard.locale.spec.js tests * FORMS-12203: Added theme request wait * Update wizard.locale.spec.js * Added latestaddon check * Delete ui.tests/test-module/package-lock.json * Update commands.js * Revert "Delete ui.tests/test-module/package-lock.json" This reverts commit fd97b53. * Reverted package-lock.json changes * FORMS-12203: Removed exception inline * FORMS-12203: Resolved comments * FORMS-12203: Update index.js * FORMS-12203: Removed package-lock.json change * Update index.js * Update error message in index.js * Update index.js * Update wizard.locale.spec.js * Removed an intercept * Updated regex patterns --------- Co-authored-by: Shivangi Mittal <[email protected]>
* FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) * Update space character for thousands separator in french lang * FORMS-13851 Support for language in date picker and number input @review @vdua DOD(Yes) --------- Co-authored-by: Varun Dua <[email protected]>
Devtomaster 18 apr
#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js
This reverts commit 63e3561.
…d submit() rule in examples (#1191) * FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers * FORMS-13209: updated af2 runtime version * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit() * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated submission handler test * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions * FORMS-13209: minor update --------- Co-authored-by: Arun Kumar Attri <[email protected]>
#1196) * FORMS-12822 : format should not be visible when no pattern is selected * FORMS-12822 : changes var to let as per ES6 in utils.js
This reverts commit 63e3561.
…d submit() rule in examples (#1191) * FORMS-13209: added check to override hardcoded submitSuccess and submitError hadnlers * FORMS-13209: updated af2 runtime version * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: replaced submit(custom:submitSuccess, custom:submitError) examples and it rules with submit() * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated submission handler test * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added rule editor authoring cypress tests * FORMS-13209: added submission handler rule tests * FORMS-13209: updated af-custom-functions version * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: updated tests * FORMS-13209: added af-custom-functions in FormView and replaced hardcoded submission handlers with defaultSubmit handlers af-custom-functions * FORMS-13209: minor update --------- Co-authored-by: Arun Kumar Attri <[email protected]>
Dev to master 29 apr
FORMS-13935 update examples for aemcomponents.dev FORMS-13935 update examples for aemcomponents.dev
…lue without default/placeholder set (#1203) * Added test case * Adding actual fix * Improved test case * Small fix
Dev to master PR
Lighthouse scores (desktop)
|
Lighthouse scores (mobile)
|
Accessibility Violations Found
|
2 similar comments
Accessibility Violations Found
|
Accessibility Violations Found
|
This reverts commit 4446d6b.
barshat7
force-pushed
the
master-to-650-3_July_24
branch
from
5aefbeb
to
a01da19
Compare
|
I have created FORMS-15321 to track the rule editor failures, these are due to incorrect CSS selectors or absence of FT, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: